DONE - BUG: Password always required when editing a user

Say you want to change only the language of this user. You make the change, click on Submit and get an error that the password is required. The password should not be required in all cases.

If the password is entered, then the following validations have to be in place:
- the repeat password field is present
- minimum length 6 characters
- password = repeat password

Also, the password is only changed if it is present and the validation is good. The file you'll have to take a look and modify are:
com.sapienter.jbilling.client.user.MaintainAction (update action)
descriptors/web/validation.xml

The fix is completed. These are the changes.

lu wrote 5 years 14 weeks ago

I'd like to take this one

Hello,

This one seems easy to start with. May I take this one up?

Thanks.

econde wrote 5 years 14 weeks ago

Go ahead Lu, I've marked the

Go ahead Lu, I've marked the task as 'in progress'.
Let me know if you need any help.

Thanks,

Emiliano Conde
Lead Developer - jbilling

Emiliano Conde
Lead Developer - jBilling

lu wrote 5 years 14 weeks ago

Thanks Emiliano.

Do we want to allow login name change and password change at the same time?

econde wrote 5 years 14 weeks ago

Yes, it'd be good if it is

Yes, it'd be good if it is possible to change them at the same time. Still, this is not critical so if it makes it very hard for you, leave it aside.

Emiliano Conde
Lead Developer - jbilling

Emiliano Conde
Lead Developer - jBilling

lu wrote 5 years 14 weeks ago

I modified the code so that

I modified the code so that password and login name can be changed at the same time. I am sending the file /usr/MaintainAction.java to jbilling-developers@lists.sourceforge.net, is that ok?

econde wrote 5 years 14 weeks ago

Lu, do your modifications

Lu, do your modifications allow to update any of the fields without having to change the password? For example, can I change the status of a user without having to enter a new password? That is the current problem that has to be solved. If your changes address this, then send them to the list email.
Also, before you submit any code, please send the contributors agreement via fax (or normal mail). See the step 5 of the 'how to contribute' guide: http://www.jbilling.com/?q=node/21&pl=gi

Cheers,

Emiliano Conde
Lead Developer - jbilling

Emiliano Conde
Lead Developer - jBilling

lu wrote 5 years 14 weeks ago

Emiliano, by moving one line

Emiliano, by moving one line of code to a different place, the initial bug was fixed; as well with that modification, a super user can update any of the fields without entering the password, plus super user can change the password at the same time the other fields are being updated.

Will send the signed agreemnt by fax today.

Cheers,

econde wrote 5 years 14 weeks ago

Hi Lu,

I've got the agreement and the code. Thanks!
The modifications fixed the bug, but removing the initial validation got other stuff broken. For example, if you enter some letters for the field 'Partner Id' you will get an error.
So the solution was pretty close: make the password 'not required' in the validation configuration (validation.xml) and make sure it passed before processing the partner id. See the changes here: http://svn.sourceforge.net/viewvc/jbilling?view=rev&revision=73

Cheers,

Emiliano Conde
Lead Developer - jbilling

Emiliano Conde
Lead Developer - jBilling

econde wrote 5 years 14 weeks ago

One line of code can be a

One line of code can be a powerful change!
Sounds good. Thanks,

Emiliano Conde
Lead Developer - jbilling

Emiliano Conde
Lead Developer - jBilling

Please register or login to post a comment.